This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Open
Conversation
added 6 commits
April 10, 2017 15:48
Contributor
|
@bkowshik @amishas157 - is this good to merge? any next actions? |
Contributor
|
Sorry @bkowshik , got late for reviewing this PR. Will be reviewing this PR by today and see the next actions here. |
amishas157
reviewed
May 10, 2017
| @@ -22,10 +22,14 @@ function invalidTagModification(newVersion, oldVersion, callback) { | |||
| var result = {}; | |||
Contributor
amishas157
reviewed
May 10, 2017
| @@ -22,10 +22,14 @@ function invalidTagModification(newVersion, oldVersion, callback) { | |||
| var result = {}; | |||
| if (!newVersion || !oldVersion) return callback(null, result); | |||
Contributor
There was a problem hiding this comment.
Now we assume that newVersion will always be present in a geojson. And if a feature is deleted, we will check for deleted tag of new version. Ref commit : 2e0e6b6
So (!newVersion || !oldVersion) will become (newVersion.deleted || !oldVersion)
Contributor
@bkowshik By that did you mean should we catch feature only when its one and only primary tag is deleted from it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses learning's from #147 to implement:
relation@amishas157 the PR also has a script to scrape data and a Jupyter notebook with all the analysis. It is ok if you review just the comparator and tests.