Conversation
|
@bkowshik @amishas157 - can we take a look at this tomorrow - the compare function looks generally good. I'll take a look at why tests are failing as well. |
|
hey @Rub21 I tried rebasing this on master and re-running the tests, and your test for the Could you check your fixtures at: https://github.com/mapbox/osm-compare/blob/rub21/tests/fixtures/big_buildings.json It seems like the last fixture has an expectedResult of true, but the comparator is returning an empty object. Let me know if I can help - this looks good to me if we can fix tests and rebase against master. |
|
Hi @Rub21 @batpad |
cc. @bkowshik