Skip to content

Conversation

@josxha
Copy link
Contributor

@josxha josxha commented Nov 8, 2025

Rationale

I noticed that the github release link has an outdated format.

image

Changes in this PR

  • Fixes the github release link
  • Open the release page in a new tab to match the behavior of the other header links.
  • The tests used v0.0.0-test as mock value, updated it to 0.0.0-test to match the actual format

Copilot AI review requested due to automatic review settings November 8, 2025 23:45
@josxha josxha changed the title fix link to github release in web-ui fix: broken url to github release in web-ui Nov 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub release link for the Martin version badge to include the "martin-v" prefix and opens the link in a new tab.

  • Updated the release tag URL format from tag/{version} to tag/martin-v{version} to match the actual GitHub release tag naming convention
  • Added target="_blank" to open the version link in a new tab

Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report and the fix ❤️

@CommanderStorm CommanderStorm enabled auto-merge (squash) November 9, 2025 15:53
@CommanderStorm CommanderStorm merged commit 1496067 into maplibre:main Nov 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants