Draft
Conversation
|
Contributor
In step 2, what does it mean to delete tasks from the challenge (which was created with no tasks)? The challenge doesn't have any tasks, and I'm not sure what step 2 is meant to accomplish. |
Contributor
Author
|
Step 2 just gets the challenge to break, a user is able to attempt to delete tasks in a challenge if it has no tasks. In the discussion were this bug was brought to attention, the user that found the bug did this on accident when they were managing their challenges. Im open to other solutions... we could add a "created" status default to the status column in the challenge table, or somethng else. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue originally discussed in slack #maproulette-dev channel: https://osmus.slack.com/archives/C04M1NHPEQY/p1730405450254649
Issue: Challenges are unable to be edited in many ways whenever a task is in the process of deleting tasks. There is an edge case scenario, that this pr fix's, were the "deleting tasks" status on a challenge persists indefinitely.
Steps to reproduce bug bug:
This is fixed by preventing the challenge status resetting after all tasks are deleted if there was no original status.