Fix edit button verbage #2784
Draft
Fix edit button verbage #2784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oss the application
- Updated test descriptions for better understanding. - Changed the test to check for the presence of a breadcrumb instead of a specific text. - Adjusted the button text assertion to reflect the new fixed status.
jake-low
requested changes
Feb 10, 2026
Contributor
jake-low
left a comment
jake-low
left a comment
There was a problem hiding this comment.
I think some of these changes might be confusing, in particular the "Edit in Foo" -> "Open in Foo Editor" changes, for these reasons:
- "Edit in X" makes it clear that this will let you modify something (the data in OSM), but "Open in" could me misinterpreted as merely viewing the data, leading users to be confused when the button launches them into an editing workflow
- By rephrasing to "Open in X Editor", we're adding an "Editor" suffix to each editor's name. For some of these editors, that leads to an unusual phrasing of the name (at least in English). Specifically, while both "iD" and "the iD editor" are in common use, I've rarely heard anyone say "the JOSM editor" or "the Level0 editor". The shorter forms "JOSM" and "Level0" are far more common.
- "Edit in X" matches the phrasing of the Edit button on openstreetmap.org, which the MapRoulette edit button draws inspiration from.
On the other hand, I think the "Default Editor" -> "Default External Editor" changes are fine, and help clarify what those settings do.
Collaborator
Author
|
What do you think about the location change. Highlighted in this comment: #2701 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2701