Fix: Use Rails::Engine for Propshaft compatibility#72
Open
mickeytgl wants to merge 2 commits intomarcoroth:mainfrom
Open
Fix: Use Rails::Engine for Propshaft compatibility#72mickeytgl wants to merge 2 commits intomarcoroth:mainfrom
mickeytgl wants to merge 2 commits intomarcoroth:mainfrom
Conversation
ReActionView's dev-tools assets were not found when using Propshaft (Rails 8's default asset pipeline) because it used Sprockets-specific asset path registration. Changed from Rails::Railtie to Rails::Engine, which automatically registers app/assets directories with both Sprockets and Propshaft.
Author
|
@marcoroth No rush, but small bump |
marcoroth
reviewed
Feb 11, 2026
lib/reactionview/railtie.rb
Outdated
Comment on lines
-5
to
-11
| # If you don't want to precompile ReActionView's assets (eg. because you're using propshaft), | ||
| # you can do this in an initializer: | ||
| # | ||
| # config.after_initialize do | ||
| # config.assets.precompile -= ReActionView::Railtie::PRECOMPILE_ASSETS | ||
| # end | ||
| # |
Owner
There was a problem hiding this comment.
I think we still want to keep this comment, no?
marcoroth
reviewed
Feb 11, 2026
| # config.assets.precompile -= ReActionView::Railtie::PRECOMPILE_ASSETS | ||
| # end | ||
| # | ||
| class Engine < Rails::Engine |
Owner
There was a problem hiding this comment.
I'm confused why we need this 🤔
I have been using ReActionView in multiple apps with Propshaft and haven't come across this error. I wonder if it's something else that might be causing this issue. And coincidentally, changing to an Engine makes it go away too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReActionView's dev-tools assets were not found when using Propshaft because it used Sprockets-specific asset path registration.
Changed from Rails::Railtie to Rails::Engine, which automatically registers app/assets directories with both Sprockets and Propshaft.
I did notice the comment suggesting to put
config.assets.precompile -= ReActionView::Railtie::PRECOMPILE_ASSETSin the initializer once I dug in and that works well, but I think it's still worth it since this would fix the root cause and it saves some time for people on propshaft from running into an errorExample