allow validation mode to be configured#81
Open
joelhawksley wants to merge 1 commit intomarcoroth:mainfrom
Open
allow validation mode to be configured#81joelhawksley wants to merge 1 commit intomarcoroth:mainfrom
joelhawksley wants to merge 1 commit intomarcoroth:mainfrom
Conversation
The default validation mode of :overlay causes false positives and difficult to debug tests. While I think we should always set it to `:raise` in tests, this PR takes the first step of making it configurable by consumers.
Author
|
@marcoroth friendly nudge on this one ❤️ |
Owner
|
@joelhawksley sorry for the lack of activity here, I'm coming back to ReActionView after the Herb v0.9 release 🙌🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default validation mode of :overlay causes false positives and difficult to debug tests. While I think we should always set it to
:raisein tests, this PR takes the first step of making it configurable by consumers.Related: #82 (probably should have filed that issue in this repo, let me know if you'd like it moved)