Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Light2Dark
commented
Feb 20, 2026
052cb0d to
408ec55
Compare
dmadisetti
reviewed
Feb 23, 2026
| @app.cell() | ||
| def _(): | ||
| print("running internal tests") | ||
| return |
Collaborator
There was a problem hiding this comment.
We might consider disabling the rule that removes trailing returns.
We use return currently to delimit the end of a cell. So a cell like:
@app.cell
def _():
print("running internal tests")
# Some comments about the test we want to run
# will get removed. Added whitespace too.
returnMay remove the comments/whitespace when formatting with ruff.
We've attempted to keep parity with ruff's formatting, and could probably support the stripped return when there is not whitespace on the last line.
dmadisetti
reviewed
Feb 23, 2026
| def add(a: int, b: int) -> int: | ||
| return a + b | ||
|
|
||
| pass |
Collaborator
There was a problem hiding this comment.
Required for the failing test, but you could make this any expression
Collaborator
|
I wouldn't mind revisiting this. My local ruff got bumped, and ran into this accidentally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This is a slow migration to use the newest version of ruff which has more rules. https://github.com/astral-sh/ruff/releases
Ran
uvx ruff check --fix. Went through the changes, they all look good.🔍 Description of Changes
📋 Checklist