fix: detect symlinked files inside assets directory for follow_symlink warning#8474
Merged
dmadisetti merged 2 commits intomainfrom Feb 27, 2026
Merged
fix: detect symlinked files inside assets directory for follow_symlink warning#8474dmadisetti merged 2 commits intomainfrom
dmadisetti merged 2 commits intomainfrom
Conversation
…k warning The previous check only detected when the assets/ directory itself was a symlink. With pdm/uv, the directory is real but files inside are symlinks, causing silent 404s. Now samples files within the directory too.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
cc @drewp |
dmadisetti
reviewed
Feb 27, 2026
| for i, child in enumerate(directory.iterdir()): | ||
| if child.is_symlink(): | ||
| return True | ||
| if i >= 1: |
Collaborator
There was a problem hiding this comment.
1 directory is not a very large sample? would maybe move to kwarg if we need to change it in the future
Contributor
Author
There was a problem hiding this comment.
this is 2 items. i don't want to read a bunch of files on startup
Contributor
Author
There was a problem hiding this comment.
and only provides a warning has not functional changes
dmadisetti
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous check only detected when the assets/ directory itself was a
symlink. With pdm/uv, the directory is real but files inside are symlinks,
causing silent 404s. Now samples files within the directory too.