Skip to content

fix: remove SVG <title> tooltip from marimo icons#8595

Merged
mscolnick merged 1 commit intomarimo-team:mainfrom
daizutabi:fix-marimo-icon-title
Mar 6, 2026
Merged

fix: remove SVG <title> tooltip from marimo icons#8595
mscolnick merged 1 commit intomarimo-team:mainfrom
daizutabi:fix-marimo-icon-title

Conversation

@daizutabi
Copy link
Contributor

📝 Summary

This is a follow-up to PR #8471.

PR #8471 added an inline <title> to MarimoIcon to satisfy an a11y lint rule. However, browsers render SVG <title> as a native hover tooltip, which shows up in the UI (e.g., in the file tree) and breaks the app's look and feel.

🔍 Description of Changes

  • Remove the inline <title> from MarimoIcon (prevents the native hover tooltip)
  • Add aria-hidden={true} to the <svg>

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • Tests have been added for the changes made.
  • Documentation has been updated where applicable, including docstrings for API changes.
  • Pull request title is a good summary of the changes - it will be used in the release notes.

@vercel
Copy link

vercel bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marimo-docs Ready Ready Preview, Comment Mar 6, 2026 10:17am

Request Review

@mscolnick mscolnick merged commit 607bf74 into marimo-team:main Mar 6, 2026
23 of 24 checks passed
@github-actions
Copy link

github-actions bot commented Mar 6, 2026

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.20.5-dev19

@daizutabi daizutabi deleted the fix-marimo-icon-title branch March 6, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants