Skip to content

feat: add cpp folder icons#3306

Open
jorduino wants to merge 8 commits into
material-extensions:mainfrom
jorduino:cpp-folder-icon
Open

feat: add cpp folder icons#3306
jorduino wants to merge 8 commits into
material-extensions:mainfrom
jorduino:cpp-folder-icon

Conversation

@jorduino
Copy link
Copy Markdown

@jorduino jorduino commented Dec 29, 2025

Description

Added a folder icon for C and C++

Fixes #3087

Contribution Guidelines

@github-actions github-actions Bot added the icons PR with new icons label Dec 29, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 29, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

Comment thread icons/folder-c-open.svg
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I've reviewed the icons, and I've the feeling that the motifs are still a little bit small compared to our other folder icons. So maybe we can adjust the design here a little bit so that it fits better.

Additionally, the c++ icon looks different on the file and for the folders:

Image

Usually, we try to have some consistent styling here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely agree with what you're saying about the C++ folder, and personally I think the C# folder is worse at adhering to the file icon design.

The problem I was running into is trying to align the ++ to the middle of the C while keeping it aligned to the grid, but I found a compromise. I aligned the ++ to the grid and to the middle of the C, but increased the C by 1 pixel (now exactly half of the scale of the file icon).

This puts the C slightly off of the grid, but to my eye it doesn't add any blur at 16x16. Please let me know what you think and I will update the C and C# folders to align with this design as well if it works

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the C and C# folder icons and I think they look better now.

The C glyph looks ever so slightly blurrier, but I don't think it's too bad at this scale:
new-c-and-friends

The folder icons still don't look exactly the same as the file icons, but I couldn't find anything that looked better at that scale.

This is using the same icon for the file just scaled down by 0.5x:
bad-cpp-folder-1

And here at full scale, obviously way too big:
crazy-cpp-folder-1

The problem is the ++ in the file icon is 1px wide and can't be scaled down any without losing clarity. Hopefully these icons work, let me know what you think.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response, I'm little bit busy at the moment. I need to spend some time to play around with your suggestions, I'm not sure if we can merge it like that. But it's on my list and I'll come back to it when there's little more time. Keep your PR open for now, it has potential.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the icon does not work i mean the icon for the "cpp" folder
image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ProgramerXYZ This PR is still open and not merged yet.

@jorduino jorduino requested a review from PKief January 11, 2026 15:21
@lucas-labs lucas-labs self-requested a review February 2, 2026 13:45
@SayanShankhari
Copy link
Copy Markdown
Contributor

SayanShankhari commented Apr 28, 2026

Are these ok?
Use close to official colors btw.
If granted, i'll shorten the svg code.

@PKief should i have to move these ones by one pixel up too?

@PKief
Copy link
Copy Markdown
Member

PKief commented May 2, 2026

@SayanShankhari yes following the existing pattern would be better, moving one pixel up will be better. However, I don't like the icon proposals yet, The plus icons don't look nice right now

@SayanShankhari
Copy link
Copy Markdown
Contributor

SayanShankhari commented May 2, 2026

well, do you have any recommendation for the double plus?
i was thinking about this one, but it reduces room for C, also does deviate from the original one.

Or would you prefer Cpp instead of C++
Also i think clarity gets more precedence than using exact same icon for file and folder.

Or, how about this, although the two pluses (3x3) reduces to dots in smol preview.

@SayanShankhari
Copy link
Copy Markdown
Contributor

SayanShankhari commented May 8, 2026

idk, it looks good to me, but i'd suggest to change the original icon colors

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon Request]: C and C++ Folder

5 participants