fix job_kwargs#869
Open
gpetretto wants to merge 1 commit intomaterialsproject:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #860 and in #856, the
@jobdecorator keeps a reference to the inputjob_kwargsand this could lead to inconsistencies if one of the arguments is modified in place.This PR implements the proposed fix, which consists in the deepcopy of the
job_kwargs. Of course there would be a slow down if many jobs with a custom JobConfig are created when submitting a flow. I am not sure if there could be any better solution that avoids it.