Skip to content

Conversation

@peternewman
Copy link
Contributor

No description provided.

@mathertel
Copy link
Owner

Only 2 typos found. Great.
Thanks for the GitHub actions file. I am not familiar with these actions (yet).
Do you know if there is an Arduino build task available to check compilation results or source code static analysis?

@peternewman
Copy link
Contributor Author

Thanks for the GitHub actions file. I am not familiar with these actions (yet).

Yeah not too much to know with a built action like the codespell one, just some program specific config (like if you were running it on the CLI). Compared to running the tool yourself where the action would have to download and install lots of stuff.

The lack of other typos may be because I'd added a codespell run to Travis and fixed them at that point:
https://github.com/mathertel/DmxSerial2/pull/14/files?diff=unified&w=1

Do you know if there is an Arduino build task available to check compilation results or source code static analysis?

I think so, you could start by turning on Travis (.org or .com, despite their claims the former still appears to be alive):
#8 (comment)

The next easiest thing is probably just to port the existing Travis PlatformIO config to Github:

DmxSerial2/.travis.yml

Lines 14 to 23 in 854fb21

matrix:
fast_finish: true
include:
- env: BOARD=teensy20 PLATFORMIO_CI_SRC=examples/RDMSerialRecv
- env: BOARD=teensy20pp PLATFORMIO_CI_SRC=examples/RDMSerialRecv
- env: BOARD=uno PLATFORMIO_CI_SRC=examples/RDMSerialRecv
- env: BOARD=diecimilaatmega328 PLATFORMIO_CI_SRC=examples/RDMSerialRecv
- env: BOARD=leonardo PLATFORMIO_CI_SRC=examples/RDMSerialRecv
- env: BOARD=nanoatmega328 PLATFORMIO_CI_SRC=examples/RDMSerialRecv
- env: BOARD=pro16MHzatmega328 PLATFORMIO_CI_SRC=examples/RDMSerialRecv

- if [[ "$TASK" != "codespell" ]]; then pip install --upgrade platformio; fi

platformio ci --lib="." --board=$BOARD

But I'll see if I can find the Arduino actions, I was talking to some of their people about codespell a while back.

@peternewman peternewman mentioned this pull request Jun 8, 2021
@peternewman
Copy link
Contributor Author

peternewman commented Jun 8, 2021

It looks like @per1234 has indeed worked their magic, see for example:
https://github.com/arduino-libraries/Arduino_APDS9960/tree/master/.github/workflows

Which I'll open a new PR to test out... #35

@peternewman
Copy link
Contributor Author

I think we all got a bit distracted with the other actions in #35 and beyond. Can this be merged as is given it's distinct from them?

@mathertel mathertel merged commit ae13015 into mathertel:master Jul 10, 2021
@peternewman peternewman deleted the patch-4 branch July 13, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants