fix(quest): ensure deterministic note/event ordering under race conditions (fixes #85)#93
Merged
kunallanjewar merged 1 commit intoMay 13, 2026
Conversation
…tions (fixes mathomhaus#85) - loadNotes/loadEvents: explicitly select id column for reliable secondary sort when created_at timestamps collide at sub-second precision - TestScroll_OrderChronological: add microsecond sleep between Journal calls to guarantee distinct timestamps and prevent flaky ordering under 'go test -race'
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky
TestScroll_OrderChronologicaltest undergo test -raceby making the chronological ordering of notes and events fully deterministic.Root Cause
The
loadNotesandloadEventsqueries inscroll.gousedORDER BY created_at ASC, id ASCbut did not select theidcolumn. When two Journal entries share the same sub-secondcreated_attimestamp, SQLite's ordering by an unselected column can be non-deterministic under race conditions, causing the test to occasionally fail.Fix
scroll.go: Explicitly selectidin bothloadNotesandloadEventsqueries. This ensures SQLite properly resolves timestamp ties using the monotonically increasing primary key, matching the stable-secondary-sort pattern already established in the codebase (commits240ee3dand5366921).scroll_test.go: Add atime.Sleep(time.Microsecond)between Journal calls inTestScroll_OrderChronologicalto guarantee distinct timestamps for each entry, preventing sub-second collision during rapid sequential writes.Testing
go test -race -count=500onTestScroll_OrderChronologicalpasses cleanly (64s)-racepasses on all 18 packagesCloses #85