Add user_mapping to config #194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added user_mapping to config remap user ID
Added reverse user mapping mapping
ldap_auth_provider.py
Outdated
Comment on lines
198
to
199
| # If username is already mapped (from previous login), reverse it for LDAP queries | ||
| original_username = self._reverse_user_mapping(username) |
Member
There was a problem hiding this comment.
What if one changes their config partway through and the mapping is updated?
Author
There was a problem hiding this comment.
In my case and most cases dont change mapping config but you are right. I made it new way with use of table user_external_ids. Is it good idea?
Author
There was a problem hiding this comment.
Hi I would ask if somebody looked on my code? I use it now in my company so some beta tests are made.
PS: Now I am woking on sync LDAP groups to room/space membership #166
implement savig to table user_external_ids
Updated examples.
Removed section on combining user mapping with Active Directory from README.
Removed user mapping troubleshooting section from README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we have in our company AD numeric ID so i need remap it to anoher. Added user_mapping to config to remap user ID.