fix: collect pre-commit hooks when squashing on clean worktree#695
Merged
fix: collect pre-commit hooks when squashing on clean worktree#695
Conversation
`collect_merge_commands()` only collected pre-commit hooks when the worktree was dirty, but squash operations can create commits even on clean worktrees. Added `squash_enabled` parameter so pre-commit hooks are collected for approval when either the worktree is dirty OR squash is enabled. Co-Authored-By: Claude <noreply@anthropic.com>
Owner
Author
|
@claude resolve conflicts |
Collaborator
|
Claude finished @max-sixty's task in 4m 30s —— View job Resolving merge conflicts ✅
The merge with Verification:
Result: The merge commit has been pushed to the PR branch. The PR is now up-to-date with main and ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes pre-commit hooks bypassing the approval system when squashing on a clean worktree.
The problem:
collect_merge_commands()only collected pre-commit hooks when the worktree was dirty. However,wt merge --squashon a clean worktree with multiple commits still creates a new commit (the squashed result), so pre-commit hooks should run.The fix: Added
squash_enabledparameter tocollect_merge_commands(). Pre-commit hooks are now collected when either the worktree is dirty OR squash is enabled, ensuring they go through the approval flow.Changes
collect_merge_commands()insrc/commands/merge.rsto acceptsquash_enabledparameterwill_create_commitvariable for claritytest_merge_pre_commit_collected_for_squash_clean_worktreeTest plan
🤖 Generated with Claude Code