feat: use tilde paths in shell command hints when safe #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `escape_path_for_shell()` that shows `~` for home directory paths in copy-pasteable commands, but only when no shell escaping is needed. Falls back to quoted absolute paths when the path contains spaces or special characters (to avoid the "tilde in quotes won't expand" issue). Examples: - `/Users/alex/repo` → `~/repo` - `/Users/alex/my repo` → `'/Users/alex/my repo'` Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts: # src/path.rs
Co-Authored-By: Claude <noreply@anthropic.com>
# Conflicts: # src/config/deprecation.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
escape_path_for_shell()helper that uses~for home directory paths in copy-pasteable commands~when no shell escaping is needed; falls back to quoted absolute paths for paths with spaces/special chars~/) and Windows (~\) path separatorsExamples:
/Users/alex/repo~/repo/Users/alex/my repo'/Users/alex/my repo'Test plan
escape_path_for_shell()covering home/non-home paths, with/without spacescargo testpassespre-commit run --all-filespasses🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com