Vectorize jacobian products across functions#268
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 67.11% 67.11% -0.01%
==========================================
Files 48 48
Lines 12384 12383 -1
==========================================
- Hits 8312 8311 -1
Misses 4072 4072 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sabakhshi
approved these changes
Sep 2, 2025
ArshSaja
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Bret Naylor from the OpenMDAO team implemented this performance improvement while helping us debug some MPhys performance issues. Essentially, it changes the calculation of the total jacobian from a series of mat-vec products in a python for loop to a single mat-mat product, which should be faster when there are a lot of outputs (e.g many thickness constraints).
Expected time until merged
No rush, we should take our time to make sure this won't break anything
Type of change
Testing
Checklist
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formattedfprettifyor C/C++ code withclang-formatas applicable