Skip to content

Conversation

@whophil
Copy link
Contributor

@whophil whophil commented Apr 2, 2025

Purpose

Build with meson-python backend.

This simplifies the build system, allowing for removal of nearly all code in setup.py, which is now replaced with pyproject.toml. In addition, the meson.build files are cleaned up where possible, and updated to use the latest helpful patterns from scipy's meson files.

TODO:

  • add dynamic version
  • no IPOPT in Linux builds?

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Existing tests.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@whophil whophil requested a review from a team as a code owner April 2, 2025 06:12
@whophil whophil requested review from lamkina and sanjan98 April 2, 2025 06:12
@whophil whophil marked this pull request as draft April 2, 2025 06:12
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (e3b9417) to head (bccffe8).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #431       +/-   ##
===========================================
- Coverage   75.02%   63.37%   -11.65%     
===========================================
  Files          22       22               
  Lines        3331     3331               
===========================================
- Hits         2499     2111      -388     
- Misses        832     1220      +388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@whophil
Copy link
Contributor Author

whophil commented Apr 2, 2025

It appears the build of IPOPT bindings (and therefore the tests) are currently skipped on the linux builds. Need to resolve.

(This is in addition to SNOPT & NLPQLP, but I guess those are skipped because they are proprietary.)

@ewu63 ewu63 mentioned this pull request Apr 5, 2025
16 tasks
@ewu63 ewu63 mentioned this pull request Apr 9, 2025
13 tasks
@ewu63
Copy link
Collaborator

ewu63 commented Apr 9, 2025

Superseded by #433

@ewu63 ewu63 closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants