Skip to content

Conversation

@ewu63
Copy link
Collaborator

@ewu63 ewu63 commented Apr 13, 2025

Purpose

Adds some basic GHA tests, because we do not currently test optional optimizer installation in our docker tests and I want to make sure nothing breaks with 1) optional installation/dependency not breaking, and 2) tests get skipped properly. We should merge this one before #433 to make sure everything looks good with mesonpy.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@ewu63 ewu63 requested a review from a team as a code owner April 13, 2025 00:02
@ewu63 ewu63 requested review from kanekosh and lamkina April 13, 2025 00:02
@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.02%. Comparing base (e3b9417) to head (95ef419).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files          22       22           
  Lines        3331     3331           
=======================================
  Hits         2499     2499           
  Misses        832      832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ewu63
Copy link
Collaborator Author

ewu63 commented Apr 13, 2025

PR is ready, but we should probably consider adding cyipopt to the deps layer of the Docker containers, beside IPOPT. CC @eirikurj

@eirikurj
Copy link
Contributor

@ewu63 yes I think we should install cyipopt on the docker images.

@eirikurj
Copy link
Contributor

PR for the containers is up https://github.com/mdolab/docker/pull/281.

@ewu63
Copy link
Collaborator Author

ewu63 commented Apr 14, 2025

We can wait for Docker to be updated first, then remove the cyipopt change.

@ewu63 ewu63 requested a review from kanekosh April 17, 2025 17:21
@kanekosh kanekosh merged commit 44be6ff into main Apr 17, 2025
18 checks passed
@ewu63 ewu63 deleted the add-GHA-tests branch April 17, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants