Skip to content

Fix for issue #254 Update _.server.model.tests.js#255

Open
mringer wants to merge 1 commit intomeanjs:masterfrom
mringer:issue-254
Open

Fix for issue #254 Update _.server.model.tests.js#255
mringer wants to merge 1 commit intomeanjs:masterfrom
mringer:issue-254

Conversation

@mringer
Copy link
Copy Markdown

@mringer mringer commented Oct 7, 2016

Fixes MochaJS MochaJS Resolution Method Over Specification in test template code.

@ilanbiala
Copy link
Copy Markdown
Member

@matthewringer why is the return not necessary anymore?

@codydaig
Copy link
Copy Markdown
Member

@ilanbiala According to #254, it's returning a promise and calling .done() in which they claim causes issues with Mocha. I have not yet experienced this, but can see what might be happening.

@mringer
Copy link
Copy Markdown
Author

mringer commented Nov 29, 2016

@ilanbiala as @codydaig mentioned returning the promise and calling .done() which raises an exception with Mocha. There is a more extensive description of the problem in the original issue, and here is an instance of the same issue from Mocha's repo.

Let me know if you have any other questions.

@ilanbiala
Copy link
Copy Markdown
Member

@codydaig LGTY?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants