Fix for issue #254 Update _.server.model.tests.js#255
Open
mringer wants to merge 1 commit intomeanjs:masterfrom
Open
Fix for issue #254 Update _.server.model.tests.js#255mringer wants to merge 1 commit intomeanjs:masterfrom
mringer wants to merge 1 commit intomeanjs:masterfrom
Conversation
Member
|
@matthewringer why is the return not necessary anymore? |
Member
|
@ilanbiala According to #254, it's returning a promise and calling .done() in which they claim causes issues with Mocha. I have not yet experienced this, but can see what might be happening. |
Author
|
@ilanbiala as @codydaig mentioned returning the promise and calling .done() which raises an exception with Mocha. There is a more extensive description of the problem in the original issue, and here is an instance of the same issue from Mocha's repo. Let me know if you have any other questions. |
Member
|
@codydaig LGTY? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MochaJS MochaJS Resolution Method Over Specification in test template code.