fixed blank page caused by faulty menu injector#277
fixed blank page caused by faulty menu injector#277ai-nick wants to merge 2 commits intomeanjs:masterfrom ai-nick:master
Conversation
|
This is intended to fix the generator error that can be seen at 13:00 of this video https://www.youtube.com/watch?v=a-dn6k6Frq4&t=769s I am confused as to why the build failed, checked the logs and I am trying to figure it out but any help would be appreciated |
|
thanks. |
|
Hey thanks for letting me know!
…Sent from my iPhone
On Jun 28, 2017, at 11:27 AM, Liran Tal <notifications@github.com<mailto:notifications@github.com>> wrote:
thanks.
we'll review
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#277 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AQzrBitRYJ8AvDe0UE3IOKpcTbOLXt8lks5sIoz8gaJpZM4OFwmz>.
|
codydaig
left a comment
There was a problem hiding this comment.
1.) I believe that it is menuService and not Menus. The service is titled menuService.
Here's the article module using it: https://github.com/meanjs/mean/blob/master/modules/articles/client/config/articles.client.menus.js#L8
Here's the actual service definition:
https://github.com/meanjs/mean/blob/master/modules/core/client/services/menu.client.service.js#L6
2.) Be sure to not include .DS_Store files! They like to sneak into PRs.
|
Thanks cody! do you think it might be that im using an older version, for some reason when i use yo generate meanjs, it templates my core with the menu service name "Menus", here is a link to my c9: https://ide.c9.io/nickwilliamswebdev/webdev-bootcamp , feel free to poke around. |
|
I believe when using the yo generator to create the project, this is the template being used for the core module: https://github.com/meanjs/generator-meanjs/blob/master/angular-config/templates/_.client.config.js Maybe we could just change generator-meanjs/angular-config/templates/_.client.config.js |
No description provided.