Skip to content

fixed blank page caused by faulty menu injector#277

Open
ai-nick wants to merge 2 commits intomeanjs:masterfrom
ai-nick:master
Open

fixed blank page caused by faulty menu injector#277
ai-nick wants to merge 2 commits intomeanjs:masterfrom
ai-nick:master

Conversation

@ai-nick
Copy link
Copy Markdown

@ai-nick ai-nick commented Jun 26, 2017

No description provided.

@ai-nick
Copy link
Copy Markdown
Author

ai-nick commented Jun 28, 2017

This is intended to fix the generator error that can be seen at 13:00 of this video https://www.youtube.com/watch?v=a-dn6k6Frq4&t=769s I am confused as to why the build failed, checked the logs and I am trying to figure it out but any help would be appreciated

@lirantal lirantal self-assigned this Jun 28, 2017
@lirantal lirantal requested a review from codydaig June 28, 2017 17:27
@lirantal
Copy link
Copy Markdown
Member

thanks.
we'll review

@ai-nick
Copy link
Copy Markdown
Author

ai-nick commented Jun 28, 2017 via email

Copy link
Copy Markdown
Member

@codydaig codydaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.) I believe that it is menuService and not Menus. The service is titled menuService.
Here's the article module using it: https://github.com/meanjs/mean/blob/master/modules/articles/client/config/articles.client.menus.js#L8

Here's the actual service definition:
https://github.com/meanjs/mean/blob/master/modules/core/client/services/menu.client.service.js#L6

2.) Be sure to not include .DS_Store files! They like to sneak into PRs.

@ai-nick
Copy link
Copy Markdown
Author

ai-nick commented Jul 2, 2017

Thanks cody! do you think it might be that im using an older version, for some reason when i use yo generate meanjs, it templates my core with the menu service name "Menus", here is a link to my c9: https://ide.c9.io/nickwilliamswebdev/webdev-bootcamp , feel free to poke around.

@ai-nick
Copy link
Copy Markdown
Author

ai-nick commented Jul 2, 2017

I believe when using the yo generator to create the project, this is the template being used for the core module: https://github.com/meanjs/generator-meanjs/blob/master/angular-config/templates/_.client.config.js Maybe we could just change generator-meanjs/angular-config/templates/_.client.config.js
of the mean generator to be menuService to match everything else, should I submit a pull request for this and close this one? (last edit, I will delete the .DS_Store files :))

@ai-nick ai-nick closed this Jul 2, 2017
@ai-nick ai-nick reopened this Jul 2, 2017
@lirantal lirantal removed their assignment Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants