Took a stab at recursive uploads including relative path prefixes#1
Open
Dorthu wants to merge 1 commit intomechpaul:masterfrom
Open
Took a stab at recursive uploads including relative path prefixes#1Dorthu wants to merge 1 commit intomechpaul:masterfrom
Dorthu wants to merge 1 commit intomechpaul:masterfrom
Conversation
I think this should do it; I haven't gotten any errors when testing it locally, and it produces the output I'd expect. I'm not sure how it compares to what you had.
Author
|
Testing this a little more, I can reproduce your SignatureDoesNotMatch error, but I get the same error using the unmodified plugin to upload only that file, suggesting it's unrelated (but there is a different bug present). |
Author
|
Looking a little harder, I think it has to do with some characters in the file name. In my case, it's a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this should do it; I haven't gotten any errors when testing it
locally, and it produces the output I'd expect. I'm not sure how it
compares to what you had.
I put this PR up against your branch, so if you merge it it will become part of linode#277