Update makederiv #299
Open
Update makederiv #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "TC" suffix to timecode overlay files
dericed
reviewed
Mar 2, 2023
| SUFFIX="_SLATE" | ||
| fi | ||
| if [[ "${TCBURN}" = "Y" ]]; then | ||
| SUFFIX="_TC" |
Collaborator
There was a problem hiding this comment.
This one would override the previous SLATE one. We should use SUFFIX+="_TC"
Collaborator
There was a problem hiding this comment.
that would require an unset SUFFIX before the suffix has the potential to be evaluated so we don't have a loop of "_TC_TC_TC" when multiple files are processed in one action.
Collaborator
There was a problem hiding this comment.
Also if you move the if then TC to go after the if statement that contains it then it would only need to be said once rather than multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "TC" suffix to timecode overlay files