Skip to content

Conversation

@tornadia
Copy link

Description

It's just a WIP, can be used as reference for anyone who is trying to build on Linux. Sound is currently disabled by hardcoding, some idiot keeps breaking the -DTOGGLE_AUDIO flag and force including it on all builds. Also why is Mehah no longer following a parametrized variable? I.e., https://github.com/edubart/otclient/blob/master/src/framework/CMakeLists.txt ;; see how it includes ${framework_SOURCES} at the end instead of manually decelaring everything?

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Server Version:
  • Client:
  • Operating System:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@majestyotbr majestyotbr changed the title build-system: builds on linux ... again [WIP] improve: update linux build Oct 24, 2025
@mehah
Copy link
Owner

mehah commented Oct 24, 2025

@tornadia, I don't use cmake, but you can ask @beats-dh and @dudantas

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Stale label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants