Fix FEM/LNA enbaled by default for Heltec T096, Heltec Wireless Tracker v2

[weebl2000]

Should only really be disabled when it causes issues. It's enabled by default on all similar Heltec boards.

[weebl2000]

@liamcottle small one. Confirmed with Heltec that they also would like it enabled by default

[liamcottle]

@liamcottle small one. Confirmed with Heltec that they also would like it enabled by default

Cool, thanks! Can you please rebase against dev.

[weebl2000]

@liamcottle small one. Confirmed with Heltec that they also would like it enabled by default

Cool, thanks! Can you please rebase against dev.

Whoops, done.

[NickDunklee]

@liamcottle Oddly, this commit was referenced in the release notes, I was going to close my PR as it already does (some of) what this PR does, but it seems between this PR and subsequent PRs, lna-enabled: false is still what is in main, and what likely shipped, despite what Heltec wanted (and what makes the most sense anyway, as RX is hampered with it turned off.)

It seems Main just shows the original commit because of the commit-stomping the last few months: https://github.com/meshcore-dev/MeshCore/commits/main/variants/heltec_t096/LoRaFEMControl.h

My PR for reference, but pull 2340 is probably the one that should be implemented since it covers more node types. I can strip mine down to just be a code-cleanup PR.

Just an FYI to bring attention to this. 🫡

[weebl2000]

@liamcottle Oddly, this commit was referenced in the release notes, I was going to close my PR as it already does (some of) what this PR does, but it seems between this PR and subsequent PRs, lna-enabled: false is still what is in main, and what likely shipped, despite what Heltec wanted (and what makes the most sense anyway, as RX is hampered with it turned off.)

It seems Main just shows the original commit because of the commit-stomping the last few months: https://github.com/meshcore-dev/MeshCore/commits/main/variants/heltec_t096/LoRaFEMControl.h

My PR for reference, but pull 2340 is probably the one that should be implemented since it covers more node types. I can strip mine down to just be a code-cleanup PR.

Just an FYI to bring attention to this. 🫡

Seems it was disabled again in #2439