feat: add WiFi companion radio env for LilyGo T3-S3 V1#2585
Open
adradr wants to merge 1 commit into
Open
Conversation
Mirrors Heltec_v3_companion_radio_wifi 1:1; only the `extends` ref changes. The WiFi runtime path (#ifdef WIFI_SSID in examples/companion_radio/main.cpp) already ships for Heltec V3 / RAK3112 / T-Beam Supreme, so this is a pure config-only enablement. Also enables the _companion_radio_wifi suffix in build.sh's companion release loop, unblocking the 16 already-merged WiFi envs that are currently built locally but never shipped via the companion-vX.Y.Z release tags. Tested on hardware: device joins WiFi, OLED shows IP, TCP port 5000 reachable, companion protocol responds correctly to APP_START and DEVICE_QUERY frames. Refs meshcore-dev#387, meshcore-dev#1134.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
LilyGo_T3S3_sx1262_companion_radio_wifi— a WiFi companion radio variant for the LilyGo T3-S3 V1 board. The env block is a 1:1 mirror ofHeltec_v3_companion_radio_wifi, just swapping theextends =reference. No source code changes.Also enables the
_companion_radio_wifisuffix inbuild.sh's companion release loop, which has the side effect of starting to ship WiFi binaries for every board that already has a_companion_radio_wifienv upstream but isn't currently included in thecompanion-vX.Y.Zrelease tag (see "Side effect" below).Refs:
Motivation
The T3-S3 V1 (ESP32-S3 + SX1262 + SSD1306 OLED) is structurally identical to the Heltec V3 from the WiFi companion stack's perspective — same MCU family, same radio, same display. The WiFi runtime path (
#ifdef WIFI_SSIDinexamples/companion_radio/main.cppandexamples/companion_radio/ui-new/UITask.cpp) already ships and is exercised byHeltec_v3_companion_radio_wifi,RAK_3112_companion_radio_wifi,T_Beam_S3_Supreme_SX1262_companion_radio_wifi, and others. T3-S3 owners are the largest LilyGo group without a WiFi build today.Changes
variants/lilygo_t3s3/platformio.ini[env:LilyGo_T3S3_sx1262_companion_radio_wifi]block. No source code changes, no custom partition CSV, noupload_flagsoverride, no display/board hardware definitions to add — all inherited from the existing[LilyGo_T3S3_sx1262]base block.build.shbuild_all_firmwares_by_suffix "_companion_radio_wifi"insidebuild_companion_firmwares(). Mirrors the existing_usband_blelines.Total: 2 files, 25 lines, 0 source code changes.
Build sizes (default board partition, no override needed):
Test plan
default.csvpartition (no override needed).APP_START(0x01) andDEVICE_QUERY(0x16 0x03), receiving validPACKET_SELF_INFOandPACKET_DEVICE_INFO.Side effect —
build.shblast radiusThe added
build_all_firmwares_by_suffix "_companion_radio_wifi"line is upstream of any_wifienv. After this lands, the nextcompanion-vX.Y.Ztag will start producing release binaries for the following WiFi envs that are already in the tree but currently silently skipped by the release loop:If maintainers prefer to land the
build.shline separately so the blast radius can be sanity-checked independently of this T3-S3 env, happy to split into two PRs.Out of scope (acknowledged)
I'm aware of in-flight work that may eventually replace or supersede the compile-time
WIFI_SSID/WIFI_PWDpattern:If/when one of those lands, this env benefits uniformly along with all other
_companion_radio_wifienvs. Not landing this env now means T3-S3 users have no upstream WiFi path today. Happy to drop the env later if maintainers decide to deprecate the compile-time approach repo-wide.Listing in the web flasher
This PR only touches the firmware repo. To make the new variant appear in
https://flasher.meshcore.io/, a companion PR tomeshcore-dev/flasher.meshcore.iois required (adding acompanionWifirole + per-board firmware entry toconfig.json). I'll open that as a follow-up once this lands and the firstcompanion-vX.Y.Zrelease contains the new binaries — same approach would benefit the other 16 WiFi envs listed above.