Replace :core:proto with org.meshtastic:protobufs:2.7.25-SNAPSHOT#5675
Draft
jamesarich wants to merge 1 commit into
Draft
Replace :core:proto with org.meshtastic:protobufs:2.7.25-SNAPSHOT#5675jamesarich wants to merge 1 commit into
jamesarich wants to merge 1 commit into
Conversation
Drop the local Wire codegen module in favor of the published KMP protobufs SDK from meshtastic/protobufs. This removes: - The git submodule (core/proto/src/main/proto) - The Wire plugin dependency - All local .proto → Kotlin code generation The TAKPacket-SDK api() export moves to :core:model which already served as the primary transitive provider of proto types. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesarich
force-pushed
the
jamesarich/migrate-to-protobufs-sdk
branch
from
99fbb55 to
a99e8cc
Compare
This was referenced May 30, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
meshtastic/protobufsKMP SDK PR landed, so we can now consume the Wire-generated models as a regular Maven dependency instead of running local codegen from a git submodule.What this does
Replaces the
:core:protomodule (local Wire codegen + git submodule pointing atmeshtastic/protobufs) with the publishedorg.meshtastic:protobufs:2.7.25-SNAPSHOTartifact. This eliminates:core/proto/src/main/proto).proto-> Kotlin code generationwire-runtimecatalog entry (now transitive from the SDK)Approach
projects.core.protonow uselibs.meshtastic.protobufsapi()export (with zstd-jni/xpp3 exclusions) moves to:core:model, which already served as the primary transitive provider of proto typessettings.gradle.ktskmpSmokeCompilepasses across JVM, Android, and iOS targetsNotes
2.7.25-SNAPSHOTbeing available on https://central.sonatype.com/repository/maven-snapshots/boxOneOfsMinSize = 5000,makeImmutableCopies = false) so generated types are ABI-compatible