fix(sim): make radio comparisons reproducible#75
Draft
Komzpa wants to merge 19 commits into
Draft
Conversation
9 tasks
0983516 to
9cba694
Compare
9cba694 to
06ad4ea
Compare
06ad4ea to
172b004
Compare
172b004 to
cf99213
Compare
cf99213 to
f72b56b
Compare
7 tasks
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f72b56b3dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
yaml.safe_loadand remove small import/string cleanupsloraMesh.pyruns when those models are enabledStack
fix(sim): make radio comparisons reproducible).Validation
.venv/bin/python -u loraMesh.py 2 --no-gui --simtime-seconds 2 --period-seconds 1 --phy-loss-model --capture-collision-model.venv/bin/python -m unittest tests.test_lora_mesh_cli tests.test_node tests.test_phy tests.test_radio_policy_compare/home/kom/.local/bin/ruff check batchSim.py lib/interactive.py lib/node.py loraMesh.py tests/test_node.py tests/test_phy.py.venv/bin/python -m compileall -q ..venv/bin/python tools/radio_policy_compare.py --simtime-seconds 5 --period-seconds 2 --policies static,dcr,dcr_dtp -- --no-clutter.venv/bin/python -m unittest(134 tests)git diff --check