[hyperactor] add NetLink enum to unify transport dispatch#2951
Closed
mariusae wants to merge 10 commits intogh/mariusae/265/basefrom
Closed
[hyperactor] add NetLink enum to unify transport dispatch#2951mariusae wants to merge 10 commits intogh/mariusae/265/basefrom
mariusae wants to merge 10 commits intogh/mariusae/265/basefrom
Conversation
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
This was referenced Mar 9, 2026
meta-cla
bot
added
the
CLA Signed
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
Introduce NetLink enum wrapping transport-specific link types (TcpLink, UnixLink, TlsLink) and implementing Link with Box<dyn Stream> as the stream type. The net::link(addr) constructor dispatches based on channel address variant. Call sites become net::spawn(net::link(addr)?) and duplex::spawn(net::link(addr)?) instead of matching on every transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls, MetaTls) into a single Net(NetTx<M>). Stack walkthrough: https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/ Differential Revision: [D95856552](https://our.internmc.facebook.com/intern/diff/D95856552/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D95856552/)! [ghstack-poisoned]
|
This pull request has been merged in 1242c01. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Introduce NetLink enum wrapping transport-specific link types
(TcpLink, UnixLink, TlsLink) and implementing Link with
Box as the stream type. The net::link(addr) constructor
dispatches based on channel address variant.
Call sites become net::spawn(net::link(addr)?) and
duplex::spawn(net::link(addr)?) instead of matching on every
transport. Unify ChannelTxKind's four net variants (Tcp, Unix, Tls,
MetaTls) into a single Net(NetTx).
Stack walkthrough:
https://www.internalfb.com/intern/phabricator/paste/markdown/P2227090563/
Differential Revision: D95856552
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!