v2.28: Use third-party doca-gpunetio instead of vendored copy#976
Open
zhiyongww wants to merge 2 commits intometa-pytorch:mainfrom
Open
v2.28: Use third-party doca-gpunetio instead of vendored copy#976zhiyongww wants to merge 2 commits intometa-pytorch:mainfrom
zhiyongww wants to merge 2 commits intometa-pytorch:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Contributor
|
@zhiyongww has exported this pull request. If you are a Meta employee, you can view the originating Diff in D95653706. |
…ytorch#975) Summary: Make NCCLx v2.29 use the third-party doca-gpunetio library instead of compiling its own vendored copy. This resolves duplicate symbol errors when tests link both NCCL (with internal doca) and ctran/pipes (with third-party doca). Changes: - Remove vendored doca-gpunetio source/header globs from def_build.bzl - Add fbsource//third-party/nvidia-doca/gpunetio:doca_gpunetio dependency - Exclude vendored doca .cpp files from transport/**/*.cpp glob - Add DOCA_VERBS_USE_META_THIRD_PARTY macro to gate Meta vs OSS build paths - Conditionally set wrapper defines and include paths based on build target Differential Revision: D95653707
…ytorch#976) Summary: Make NCCLx v2.28 use the third-party doca-gpunetio library instead of compiling its own vendored copy. This resolves duplicate symbol errors when tests link both NCCL (with internal doca) and ctran/pipes (with third-party doca). Changes: - Remove vendored doca-gpunetio source/header globs from def_build.bzl - Remove doca-gpunetio header remapping function (no longer needed) - Add fbsource//third-party/nvidia-doca/gpunetio:doca_gpunetio dependency - Add DOCA_VERBS_USE_META_THIRD_PARTY macro to gate Meta vs OSS build paths - Conditionally set wrapper defines and include paths based on build target Differential Revision: D95653706
zhiyongww
force-pushed
the
export-D95653706
branch
from
9c76129 to
ca9a64b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Make NCCLx v2.28 use the third-party doca-gpunetio library instead of compiling
its own vendored copy. This resolves duplicate symbol errors when tests link both
NCCL (with internal doca) and ctran/pipes (with third-party doca).
Changes:
Differential Revision: D95653706