fix(pulsar): Use topic_refresh_secs always#56
Open
darinspivey wants to merge 2 commits intomasterfrom
Open
Conversation
Refreshing the topics list periodically now happens both with regex subscriptions and without. This refresh value is now used across the board, so place it in the main part of the builder. Ref: LOG-23134
The code in place for acking upon failures is correct. There's some confusion with how Kafka works versus Pulsar, so this adds appropriate comments to indicate that although they operate acks differently, the end result is essentially the same when event delivery fails. Ref: LOG-23134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(pulsar): Update comments regarding acks around failures
The code in place for acking upon failures is correct. There's some
confusion with how Kafka works versus Pulsar, so this adds appropriate
comments to indicate that although they operate acks differently, the
end result is essentially the same when event delivery fails.
Ref: LOG-23134
fix(pulsar): Use
topic_refresh_secsalwaysRefreshing the topics list periodically now happens both with regex
subscriptions and without. This refresh value is now used across the
board, so place it in the main part of the builder.
Ref: LOG-23134