Feature/styleprop#462
Open
tvanlaerhoven wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace Slider's
ViewStyleprops withStyleProp<ViewStyle>.This way the style props accept not only
ViewStyletypes, but also a (recursive) array ofViewStyle, and aFalsytype, which translates tofalse || null || undefined.A user can then pass
containerStyle,minimumTrackStyle,maximumTrackStyle,thumbStyleandtrackStyleas:style={[styles.style1, styles.style2]}Falsyvalue, such asstyle={undefined}which is not possible with bare
ViewStyle.It makes it easier for
Sliderusers to optionally pass style overrides in their ownCustomSlider:The API remains backwards compatible with previous versions.