Add broadcast channel shim to fix iOS <15.4 crash#902
Closed
microbit-grace wants to merge 1 commit into
Closed
Conversation
|
Preview build will be at |
Author
|
Tested
|
Author
|
Superseded by #903 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app crashes for iOS versions earlier than 15.4 because
BroadcastChannelis not supported in those versions. A no-op version is implemented and used for those instances to avoid the crash.BroadcastChannelis used to sync project state between web tabs/windows. It doesn’t matter if it doesn’t work for native apps. However, this may be an issue for web users that use Safari versions earlier than 15.4. This can be revisited later on.