-
Notifications
You must be signed in to change notification settings - Fork 7
Add --update-endpoint option for messaging endpoint management #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds messaging endpoint management capabilities to the Agent365 CLI by introducing two new command-line options: --custom-endpoint for overriding endpoint URLs during registration, and --update-endpoint for replacing existing endpoints. The implementation provides comprehensive validation, error handling, and configuration syncing to support both Azure and non-Azure deployment scenarios.
Changes:
- Added
--custom-endpointoption toallandblueprintsetup subcommands for endpoint URL override during registration - Added
--update-endpointoption toblueprintsubcommand for deleting and re-registering messaging endpoints - Enhanced endpoint registration logic to support custom endpoint URLs with proper validation and naming conventions
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| SetupCommandTests.cs | Added tests verifying the presence and behavior of the --custom-endpoint option in the all subcommand |
| BlueprintSubcommandTests.cs | Added comprehensive tests for both --custom-endpoint and --update-endpoint options, covering success cases, validation failures, and edge cases |
| SetupHelpers.cs | Modified RegisterBlueprintMessagingEndpointAsync to accept an optional custom endpoint parameter with HTTPS validation and endpoint naming logic |
| BlueprintSubcommand.cs | Added command options, handler logic, UpdateEndpointAsync method for endpoint updates, and ResolveCustomEndpoint helper method |
| AllSubcommand.cs | Added --custom-endpoint option and integrated it into the setup workflow with dry-run logging support |
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/AllSubcommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Outdated
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/BlueprintSubcommandTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/AllSubcommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/SetupSubcommands/BlueprintSubcommand.cs
Show resolved
Hide resolved
|
Will this continue to support local endpoints like devtunnel and ngrok? Those used to be good for testing during development |
Yes, there should be no change in supported endpoints as a result of this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
This pull request adds support for custom messaging endpoint registration and endpoint updates in the Agent365 CLI setup commands. The main changes introduce anew command-line options (
--update-endpoint) for blueprint setup, allowing users to update an existing endpoint. The implementation ensures proper validation, logging, and configuration updates throughout the workflow.New CLI options and endpoint management features:
--update-endpointoption to theblueprintsetup subcommand, allowing users to delete the existing messaging endpoint and register a new one with a specified URL. This includes a new helper method for endpoint update logic, validation, and configuration syncing. [1] [2]Validation and configuration changes:
Handler and workflow integration:
These changes provide more flexibility for messaging endpoint management during agent blueprint setup, supporting advanced deployment scenarios and improving user experience.
Fixes #129 and #140