Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 24, 2026

The a365 config init command and documentation files displayed incorrect URLs for custom client app registration instructions. Additionally, several Microsoft Learn URLs throughout the codebase included hardcoded locale segments (/en-us/), preventing automatic language detection for international users.

Changes

  • Added CustomClientAppRegistrationUrl constant in ConfigConstants.cs with locale-agnostic Microsoft Learn URL
  • Updated ConfigurationWizardService.cs to use the constant
  • Updated all documentation references in README.md, docs/commands/config-init.md, and docs/commands/develop/develop-addpermissions.md to use the correct Microsoft Learn URL
  • Made all microsoft-agent-365 Microsoft Learn URLs locale-agnostic by removing /en-us/ segments:
    • Updated Agent365CliDocumentationUrl constant for consistency
    • Updated onboard URLs in A365CreateInstanceRunner.cs and CreateInstanceCommand.cs
    • Updated developer documentation URL in FrontierPreviewRequirementCheck.cs

URL Change

- https://github.com/microsoft/Agent365-devTools/blob/main/docs/guides/custom-client-app-registration.md
- docs/guides/custom-client-app-registration.md (broken relative links)
- https://learn.microsoft.com/en-us/microsoft-agent-365/... (locale-specific)
+ https://learn.microsoft.com/microsoft-agent-365/... (locale-agnostic)

All Microsoft Learn URLs now omit locale segments to enable automatic redirection based on user's browser language preferences.

Files Updated

  • src/Microsoft.Agents.A365.DevTools.Cli/Constants/ConfigConstants.cs
  • src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs
  • src/Microsoft.Agents.A365.DevTools.Cli/Services/A365CreateInstanceRunner.cs
  • src/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cs
  • src/Microsoft.Agents.A365.DevTools.Cli/Services/Requirements/RequirementChecks/FrontierPreviewRequirementCheck.cs
  • README.md
  • docs/commands/config-init.md
  • docs/commands/develop/develop-addpermissions.md
Original prompt

This section details on the original issue you should resolve

<issue_title>Custom client registration doc link is incorrect</issue_title>
<issue_description>Describe the bug
Incorrect custom client registration doc shown by CLI: https://github.com/microsoft/Agent365-devTools/blob/main/docs/guides/custom-client-app-registration.md

To Reproduce
Run:
a365 config init

Expected behavior
It should link to this page (ideally to the right locale of this doc as well): https://learn.microsoft.com/en-us/microsoft-agent-365/developer/custom-client-app-registration

Screenshots
Image

Environment (please complete the following information):

  • OS: Windows
  • SDK Version: 1.1.48-preview
    </issue_description>

<agent_instructions>Documentation links provided are incorrect. The description gives the correct link but needs that to be locale-agnostic (en-us part in URL). Update the links appropriately.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: tmlsousa <122949962+tmlsousa@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incorrect custom client registration documentation link Fix custom client registration doc link to point to Microsoft Learn Jan 24, 2026
Copilot AI requested a review from tmlsousa January 24, 2026 22:22
@tmlsousa
Copy link
Contributor

@copilot There are another few locations in the repo that reference custom-client-app-registration.md but this file does not exist anymore.
Instead this should point to the new link constant created in this pull request.

Co-authored-by: tmlsousa <122949962+tmlsousa@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 24, 2026

@copilot There are another few locations in the repo that reference custom-client-app-registration.md but this file does not exist anymore.
Instead this should point to the new link constant created...

Updated all 4 documentation references to use the Microsoft Learn URL. Changes in commit 42b0598:

  • README.md
  • docs/commands/config-init.md (2 references)
  • docs/commands/develop/develop-addpermissions.md

All broken links to the non-existent custom-client-app-registration.md file now point to https://learn.microsoft.com/microsoft-agent-365/developer/custom-client-app-registration

Copilot AI changed the title Fix custom client registration doc link to point to Microsoft Learn Fix custom client registration doc links to point to Microsoft Learn Jan 24, 2026
@tmlsousa tmlsousa marked this pull request as ready for review January 24, 2026 23:40
@tmlsousa tmlsousa requested review from a team as code owners January 24, 2026 23:40
Copilot AI review requested due to automatic review settings January 24, 2026 23:40
@tmlsousa tmlsousa enabled auto-merge (squash) January 24, 2026 23:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes incorrect documentation URLs for custom client app registration instructions throughout the Agent365 CLI codebase. The changes replace broken GitHub repository links with the official Microsoft Learn documentation URL, making it locale-agnostic for automatic language redirection based on user preferences.

Changes:

  • Added a new constant CustomClientAppRegistrationUrl in ConfigConstants.cs with the correct Microsoft Learn URL
  • Updated ConfigurationWizardService.cs to use the new constant instead of a hardcoded GitHub link
  • Updated all documentation references in README.md and docs/ files to use the correct Microsoft Learn URL

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Microsoft.Agents.A365.DevTools.Cli/Constants/ConfigConstants.cs Added new constant for custom client app registration documentation URL without locale segment
src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs Updated console output to use the new constant instead of hardcoded GitHub URL
README.md Updated setup guide link to point to Microsoft Learn documentation
docs/commands/config-init.md Updated two references to custom client app registration guide
docs/commands/develop/develop-addpermissions.md Updated custom client app registration guide link

/// <summary>
/// Microsoft Learn documentation URL for custom client app registration
/// </summary>
public const string CustomClientAppRegistrationUrl = "https://learn.microsoft.com/microsoft-agent-365/developer/custom-client-app-registration";
Copy link

Copilot AI Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new constant CustomClientAppRegistrationUrl correctly omits the locale segment (/en-us/) for automatic redirection, but the existing Agent365CliDocumentationUrl constant on line 29 still includes /en-us/. For consistency and to ensure all users get content in their preferred locale, consider updating Agent365CliDocumentationUrl to also be locale-agnostic: https://learn.microsoft.com/microsoft-agent-365/developer/agent-365-cli

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in commit 997d76f. Made all microsoft-agent-365 URLs locale-agnostic:

  • ConfigConstants.cs: Removed /en-us/ from Agent365CliDocumentationUrl
  • Also updated 3 other user-facing URLs in A365CreateInstanceRunner.cs, CreateInstanceCommand.cs, and FrontierPreviewRequirementCheck.cs

All Microsoft Learn URLs now automatically redirect based on user's locale preferences.

Co-authored-by: tmlsousa <122949962+tmlsousa@users.noreply.github.com>
Copilot AI changed the title Fix custom client registration doc links to point to Microsoft Learn Make all Microsoft Learn documentation URLs locale-agnostic Jan 27, 2026
Copilot AI requested a review from tmlsousa January 27, 2026 02:14
pontemonti
pontemonti previously approved these changes Jan 27, 2026
…equirementChecks/FrontierPreviewRequirementCheck.cs

Co-authored-by: Johan Broberg <johan@pontemonti.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom client registration doc link is incorrect

3 participants