-
Notifications
You must be signed in to change notification settings - Fork 7
Make all Microsoft Learn documentation URLs locale-agnostic #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: tmlsousa <122949962+tmlsousa@users.noreply.github.com>
|
@copilot There are another few locations in the repo that reference custom-client-app-registration.md but this file does not exist anymore. |
Co-authored-by: tmlsousa <122949962+tmlsousa@users.noreply.github.com>
Updated all 4 documentation references to use the Microsoft Learn URL. Changes in commit 42b0598:
All broken links to the non-existent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes incorrect documentation URLs for custom client app registration instructions throughout the Agent365 CLI codebase. The changes replace broken GitHub repository links with the official Microsoft Learn documentation URL, making it locale-agnostic for automatic language redirection based on user preferences.
Changes:
- Added a new constant
CustomClientAppRegistrationUrlinConfigConstants.cswith the correct Microsoft Learn URL - Updated
ConfigurationWizardService.csto use the new constant instead of a hardcoded GitHub link - Updated all documentation references in README.md and docs/ files to use the correct Microsoft Learn URL
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Microsoft.Agents.A365.DevTools.Cli/Constants/ConfigConstants.cs |
Added new constant for custom client app registration documentation URL without locale segment |
src/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cs |
Updated console output to use the new constant instead of hardcoded GitHub URL |
README.md |
Updated setup guide link to point to Microsoft Learn documentation |
docs/commands/config-init.md |
Updated two references to custom client app registration guide |
docs/commands/develop/develop-addpermissions.md |
Updated custom client app registration guide link |
| /// <summary> | ||
| /// Microsoft Learn documentation URL for custom client app registration | ||
| /// </summary> | ||
| public const string CustomClientAppRegistrationUrl = "https://learn.microsoft.com/microsoft-agent-365/developer/custom-client-app-registration"; |
Copilot
AI
Jan 24, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new constant CustomClientAppRegistrationUrl correctly omits the locale segment (/en-us/) for automatic redirection, but the existing Agent365CliDocumentationUrl constant on line 29 still includes /en-us/. For consistency and to ensure all users get content in their preferred locale, consider updating Agent365CliDocumentationUrl to also be locale-agnostic: https://learn.microsoft.com/microsoft-agent-365/developer/agent-365-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in commit 997d76f. Made all microsoft-agent-365 URLs locale-agnostic:
- ConfigConstants.cs: Removed
/en-us/fromAgent365CliDocumentationUrl - Also updated 3 other user-facing URLs in A365CreateInstanceRunner.cs, CreateInstanceCommand.cs, and FrontierPreviewRequirementCheck.cs
All Microsoft Learn URLs now automatically redirect based on user's locale preferences.
Co-authored-by: tmlsousa <122949962+tmlsousa@users.noreply.github.com>
...A365.DevTools.Cli/Services/Requirements/RequirementChecks/FrontierPreviewRequirementCheck.cs
Outdated
Show resolved
Hide resolved
…equirementChecks/FrontierPreviewRequirementCheck.cs Co-authored-by: Johan Broberg <johan@pontemonti.net>
The
a365 config initcommand and documentation files displayed incorrect URLs for custom client app registration instructions. Additionally, several Microsoft Learn URLs throughout the codebase included hardcoded locale segments (/en-us/), preventing automatic language detection for international users.Changes
CustomClientAppRegistrationUrlconstant inConfigConstants.cswith locale-agnostic Microsoft Learn URLConfigurationWizardService.csto use the constantREADME.md,docs/commands/config-init.md, anddocs/commands/develop/develop-addpermissions.mdto use the correct Microsoft Learn URL/en-us/segments:Agent365CliDocumentationUrlconstant for consistencyA365CreateInstanceRunner.csandCreateInstanceCommand.csFrontierPreviewRequirementCheck.csURL Change
All Microsoft Learn URLs now omit locale segments to enable automatic redirection based on user's browser language preferences.
Files Updated
src/Microsoft.Agents.A365.DevTools.Cli/Constants/ConfigConstants.cssrc/Microsoft.Agents.A365.DevTools.Cli/Services/ConfigurationWizardService.cssrc/Microsoft.Agents.A365.DevTools.Cli/Services/A365CreateInstanceRunner.cssrc/Microsoft.Agents.A365.DevTools.Cli/Commands/CreateInstanceCommand.cssrc/Microsoft.Agents.A365.DevTools.Cli/Services/Requirements/RequirementChecks/FrontierPreviewRequirementCheck.csREADME.mddocs/commands/config-init.mddocs/commands/develop/develop-addpermissions.mdOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.