Sync4.2.3 #191
Open
Sync4.2.3 #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit ffa010e (ci: Update Windows jobs to VS 2026, 2025-11-21, v4.2.1~28^2) we link to a MSVC C++ runtime library that implements `std::chrono::system_clock::now()` via `GetSystemTimePreciseAsFileTime`, which is only available on Windows 8 and above. Restore support for Windows 7 by reverting `windows-{x86_64,i386}` packaging from MSVC 14.50 to MSVC 14.44. Fixes: #27446
01cbab9 ci: Restore support for Windows 7 in official precompiled binaries Acked-by: Kitware Robot <[email protected]> Merge-request: !11491
1ad84c5 Tutorial: Fix path to file in exercise solution Acked-by: Kitware Robot <[email protected]> Merge-request: !11493
Fixes: #27451
Exclude infrastructure added by commit 6174347 (ast-grep: add a rule to find adjacent string literals in cmStrCat calls, 2025-05-15, v4.1.0-rc1~122^2~3).
Allow Windows users who aren't familiar with MSVC-equivalent commands to GCC and/or don't have the GNU toolchain installed (via MinGW, etc.) to practice this example.
93f5111 gitattributes: Do not export ast-grep infrastructure in source archives Acked-by: Kitware Robot <[email protected]> Merge-request: !11499
1bf4681 FindBLAS: Make find_package(nvpl) quiet Acked-by: Kitware Robot <[email protected]> Merge-request: !11498
93f5111 gitattributes: Do not export ast-grep infrastructure in source archives Acked-by: Kitware Robot <[email protected]> Reviewed-by: Ben Boeckel <[email protected]> Merge-request: !11499
1bf4681 FindBLAS: Make find_package(nvpl) quiet Acked-by: Kitware Robot <[email protected]> Tested-by: buildbot <[email protected]> Merge-request: !11498
In commit e419429 (StdIo: Restore Windows Console I/O modes on Ctrl-C, 2025-11-26, v4.1.4~4^2) we relied on the compiler to generate a lambda with an `operator()` for each calling convention. MSVC does this, but the GNU compiler for MinGW does not seem to.
…chive Commit 1b9e8f8 (Linux: Compile with 64-bit time_t even on 32-bit architectures, 2025-06-26, v4.1.0-rc2~16^2) broke running with a system-provided libarchive that uses a 32-bit `time_t`. If CMake is configured to build with a system libarchive, assume the user has taken responsibility to match `time_t` sizes. Fixes: #27448
c55dfbf StdIo: Restore compilation on 32-bit MinGW Acked-by: Kitware Robot <[email protected]> Merge-request: !11503
cea7f7f Linux: Do not force 64-bit `time_t` on 32-bit archs with system libarchive 16cc3e2 Utilities: Select bundled or external dependencies very early Acked-by: Kitware Robot <[email protected]> Merge-request: !11505
c55dfbf StdIo: Restore compilation on 32-bit MinGW Acked-by: Kitware Robot <[email protected]> Merge-request: !11503
cea7f7f Linux: Do not force 64-bit `time_t` on 32-bit archs with system libarchive 16cc3e2 Utilities: Select bundled or external dependencies very early Acked-by: Kitware Robot <[email protected]> Acked-by: buildbot <[email protected]> Merge-request: !11505
58fc663 Tutorial: Provide MSVC example to build Vendor library Acked-by: Kitware Robot <[email protected]> Merge-request: !11501
Document link flags suppressed by commit 99d09ec (VS: Suppress MSBuild default link flags not specified by project or user, 2025-06-17, v4.1.0-rc1~6^2). Leave out `-subsystem` because that's being reverted by another commit. Issue: #27004 Issue: #27464
In commit 99d09ec (VS: Suppress MSBuild default link flags not specified by project or user, 2025-06-17, v4.1.0-rc1~6^2) we removed our default `-subsystem:...` link flag from `SHARED` and `MODULE` libraries in Visual Studio generators for consistency with command-line generators. However, unlike other flag suppressions for #27004, this change did not just suppress MSBuild defaults, but actually changed flags the generator was previously adding itself. For the linker subsystem flag, consistency across generators should perhaps achieved by adding the flag in other generators instead of removing it from Visual Studio generators. Restore the previous behavior pending further investigation. Issue: #27466 Fixes: #27464
In commit 99d09ec (VS: Suppress MSBuild default link flags not specified by project or user, 2025-06-17, v4.1.0-rc1~6^2) we removed our default `-subsystem:...` link flag from `SHARED` and `MODULE` libraries in Visual Studio generators for consistency with command-line generators. However, unlike other flag suppressions for #27004, this change did not just suppress MSBuild defaults, but actually changed flags the generator was previously adding itself. For the linker subsystem flag, consistency across generators should perhaps achieved by adding the flag in other generators instead of removing it from Visual Studio generators. Restore the previous behavior pending further investigation. Issue: #27466 Fixes: #27464
91b9db9 VS: Restore subsystem link flag for DLLs Acked-by: Kitware Robot <[email protected]> Merge-request: !11524
46e59b5 Merge branch 'backport-vs-link-defaults' into vs-link-defaults b6defd9 VS: Restore subsystem link flag for DLLs 91b9db9 VS: Restore subsystem link flag for DLLs Acked-by: Kitware Robot <[email protected]> Acked-by: Alex Overchenko <[email protected]> Merge-request: !11524
ea35723 Help: Add 4.1 release note about VS link flag suppression Acked-by: Kitware Robot <[email protected]> Merge-request: !11525
ea35723 Help: Add 4.1 release note about VS link flag suppression Acked-by: Kitware Robot <[email protected]> Merge-request: !11525
Multiple tests passed a host side stack address for writing on the GPU. Now we pass a GPU backed heap address.
c238f17 Tests: Remove invalid CUDA code from tests Acked-by: Kitware Robot <[email protected]> Merge-request: !11607
c238f17 Tests: Remove invalid CUDA code from tests Acked-by: Kitware Robot <[email protected]> Merge-request: !11607
c238f17 Tests: Remove invalid CUDA code from tests Acked-by: Kitware Robot <[email protected]> Merge-request: !11607
c238f17 Tests: Remove invalid CUDA code from tests Acked-by: Kitware Robot <[email protected]> Merge-request: !11607
On Windows, since commit 9539a0d (LibArchive 2024-09-13, 2024-09-13, v3.31.0-rc1~77^2~3^2) imported libarchive commit `49280bc202a8` (Fix tests on Windows, 2024-03-23, `v3.7.3~17`), libarchive fails to extract archives whose paths are not valid MBS encodings in the host's OEM code page. This broke extraction, e.g., by `cmake -E tar` of archives with UTF-8 paths on Windows. Restore compatibility with CMake 3.30 and below by tolerating encoding conversion errors on Windows. Although affected paths are not extracted correctly, we at least succeed in extracting the rest of such archives. Issue: #26903
f590010 libarchive: Restore tolerance of archives with non-OEM paths on Windows Acked-by: Kitware Robot <[email protected]> Merge-request: !11622
f590010 libarchive: Restore tolerance of archives with non-OEM paths on Windows Acked-by: Kitware Robot <[email protected]> Merge-request: !11622
f590010 libarchive: Restore tolerance of archives with non-OEM paths on Windows Acked-by: Kitware Robot <[email protected]> Merge-request: !11622
f590010 libarchive: Restore tolerance of archives with non-OEM paths on Windows Acked-by: Kitware Robot <[email protected]> Acked-by: Alex Overchenko <[email protected]> Merge-request: !11622
CMake 4.2.3
gcampbell-msft
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your interest in contributing to CMake! The GitHub repository
is a mirror provided for convenience, but CMake does not use GitHub pull
requests for contribution. Please see
https://gitlab.kitware.com/cmake/cmake/-/tree/master/CONTRIBUTING.rst
for contribution instructions. GitHub OAuth may be used to sign in.