[SPIR-V] Support asdouble() for uint3 argument type.
#7965
Merged
+50
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luciechoi
changed the title
asdouble() for uint3 argument type.asdouble() for uint3 argument type.
Collaborator
Author
s-perron
reviewed
Dec 9, 2025
Collaborator
s-perron
left a comment
s-perron
left a comment
There was a problem hiding this comment.
The code sequence you are generating is a little verbose. Also, do we have to handle 4 element vectors as well? I think you code will handle it, but the comments do not indicate that.
If we do, we should add a test for it.
s-perron
approved these changes
Dec 15, 2025
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7699.
Previously, only
asdouble(uint, uint)andasdouble(uint2, uint2)were supported.The fix is to manually extract each component and compose a vector of doubles.
Verified asdouble.32.test is passing.