Fix incorrect OpAccessChain for inherited struct members

[s-perron]

Adds a new test case to verify that the OpAccessChain is generated correctly for inherited members of a struct.

This fixes an issue where the indices for a base class were being prepended to the indices of the derived class, resulting in an incorrect access chain.

Fixes #7968

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 948629ac48fb6fb8261d1c2dfc443e297841ade1 52cf8afad277bebd25ef9780a54c1688d1ea2ef7 -- tools/clang/lib/SPIRV/SpirvEmitter.cpp

View the diff from clang-format here.

diff --git a/tools/clang/lib/SPIRV/SpirvEmitter.cpp b/tools/clang/lib/SPIRV/SpirvEmitter.cpp
index e47d37e8..c14dc1e6 100644
--- a/tools/clang/lib/SPIRV/SpirvEmitter.cpp
+++ b/tools/clang/lib/SPIRV/SpirvEmitter.cpp
@@ -8862,8 +8862,9 @@ const Expr *SpirvEmitter::collectArrayStructIndices(
       } else if (castExpr->getCastKind() == CK_UncheckedDerivedToBase ||
                  castExpr->getCastKind() == CK_HLSLDerivedToBase) {
         // First the indices for the sub expression.
-        const Expr * base = collectArrayStructIndices(castExpr->getSubExpr(), rawIndex,
-                                         rawIndices, indices, isMSOutAttribute);
+        const Expr *base =
+            collectArrayStructIndices(castExpr->getSubExpr(), rawIndex,
+                                      rawIndices, indices, isMSOutAttribute);
 
         llvm::SmallVector<uint32_t, 4> BaseIdx;
         getBaseClassIndices(castExpr, &BaseIdx);

• Check this box to apply formatting changes to this branch.

[Keenuts]

LGTM!