[docs] Create data directory in MLX Phi-4 reasoning notebook#535
Open
danyalahmed1995 wants to merge 1 commit intomicrosoft:mainfrom
Open
[docs] Create data directory in MLX Phi-4 reasoning notebook#535danyalahmed1995 wants to merge 1 commit intomicrosoft:mainfrom
danyalahmed1995 wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates the
./datadirectory before the MLX Phi-4 reasoning fine-tuning notebook writes generated JSONL files.The notebook currently writes to
./data/train.jsonland./data/valid.jsonl, but thedatadirectory is not present in a fresh checkout and is not created before those writes.Changes
Path("data").mkdir(exist_ok=True)before exporting JSONL filestrain.jsonlandvalid.jsonloutput filenamesValidation
md/02.Application/03.AdvancedReasoning/Phi4/AdvancedResoningPhi4mini/datais absent in a fresh checkout./data/train.jsonland./data/valid.jsonl./databefore those writes