Skip to content

Conversation

@jiripolasek
Copy link
Collaborator

@jiripolasek jiripolasek commented Nov 7, 2025

Summary of the Pull Request

Caution

This implements the feature request, but the design needs more polish:
TBD:

  • Always dismiss clashes with Go home when activated, that's not intuitive

  • Options are in two different sections:

    • Activation:
      • Go home when activated
    • Behavior:
      • Backspace go back
      • Escape key behavior
  • Drop-down item labels

This PR adds a new option to the General page in Settings:

Escape key behavior — a dropdown with the following choices:

  • Clear search first, then go back

    • Current behavior.
    • If the search box contains text, it is cleared; otherwise goes back.
    • On the home page, CmdPal is dismissed.
  • Always go back

    • Leaves the search text intact.
    • If the page is not transient, the search text reappears when returning.
    • On the home page, CmdPal is dismissed.
  • Always dismiss

    • Immediately dismisses CmdPal and navigates to the home page.
    • Ignores the Go home when activated setting.
    • Search text is cleared.

This implementation preserves existing behavior, except for Always dismiss, which always forces navigation to the home page.

Pictures? Pictures!

image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@jiripolasek jiripolasek added the Product-Command Palette Refers to the Command Palette utility label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors, Warnings, and Notices Count
ℹ️ candidate-pattern 1
❌ forbidden-pattern 1
⚠️ ignored-expect-variant 4

See ❌ Event descriptions for more information.

These words are not needed and should be removed cabstr CIBUILD djwsxzxb icf installscopeperuser ksa Olllama rap registryroot regroot rtm suntimes TARGETDIR utm

Pattern suggestions ✂️ (1)

You could add these patterns to .github/actions/spell-check/patterns.txt:

# Automatically suggested patterns

# hit-count: 1 file-count: 1
# Amazon
\bamazon\.com/[-\w]+/(?:dp/[0-9A-Z]+|)

Alternatively, if a pattern suggestion doesn't make sense for this project, add a #
to the beginning of the line in the candidates file with the pattern to stop suggesting it.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Product-Command Palette Refers to the Command Palette utility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a setting for what esc does

1 participant