feat(libvirt): disable Xen/libxl driver support#16463
Open
christopherco wants to merge 1 commit intotomls/base/mainfrom
Open
feat(libvirt): disable Xen/libxl driver support#16463christopherco wants to merge 1 commit intotomls/base/mainfrom
christopherco wants to merge 1 commit intotomls/base/mainfrom
Conversation
Azure Linux targets Hyper-V/KVM, not Xen. Since our builders have the %fedora macro set, the upstream spec enables the libxl driver on x86_64/aarch64 by default, pulling in xen-devel at build time and producing libvirt-daemon-driver-libxl / libvirt-daemon-xen subpackages with libxenstore.so.4 runtime dependencies. Disable via build.without = ["libxl"]. Verified: build succeeds, no xen/libxl subpackages are produced, and no output RPMs carry xen dependencies.
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Azure Linux component configuration for libvirt to avoid building Xen/libxl support, aligning libvirt’s build output with Azure Linux’s Hyper-V/KVM focus and preventing Xen-related build/runtime dependencies when %fedora is set.
Changes:
- Add a dedicated
libvirt.comp.tomlthat disables thelibxlbuild option viabuild.without. - Remove the now-dedicated
libvirtcomponent entry fromcomponents-full.toml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
base/comps/libvirt/libvirt.comp.toml |
Introduces per-component build config to disable the libxl (Xen) driver. |
base/comps/components-full.toml |
Removes the libvirt entry since it now has a dedicated *.comp.toml file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Linux targets Hyper-V/KVM, not Xen. Since our builders have the %fedora macro set, the upstream spec enables the libxl driver on x86_64/aarch64 by default, pulling in xen-devel at build time and producing libvirt-daemon-driver-libxl / libvirt-daemon-xen subpackages with libxenstore.so.4 runtime dependencies.
Disable via build.without = ["libxl"]. Verified: build succeeds, no xen/libxl subpackages are produced, and no output RPMs carry xen dependencies.
Part of fixing: workitem