feat(grub2): disable Xen module builds#16466
Merged
reubeno merged 1 commit intotomls/base/mainfrom Apr 6, 2026
Merged
Conversation
Azure Linux targets Hyper-V/KVM, not Xen. The upstream grub.macros enables with_xen_arch and with_xen_pvh_arch on x86_64, producing grub2-xen-x64-modules and grub2-xen_pvh-i386-modules subpackages. Force both to 0 via file-search-replace overlays on grub.macros. Verified: build succeeds and no Xen module subpackages are produced.
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables Xen-specific GRUB2 module subpackage builds in Azure Linux by overriding upstream grub.macros defaults, aligning GRUB2 packaging with Azure Linux’s Hyper-V/KVM focus and avoiding unnecessary Xen module outputs.
Changes:
- Add a dedicated
grub2.comp.tomlwithfile-search-replaceoverlays to forcewith_xen_archandwith_xen_pvh_archto0. - Remove the bare
grub2entry fromcomponents.tomlnow thatgrub2has a dedicated component definition file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| base/comps/grub2/grub2.comp.toml | Introduces overlays that disable Xen module builds by editing grub.macros during source prep. |
| base/comps/components.toml | Drops the generic grub2 entry to avoid duplicate/ambiguous component definitions once the dedicated file exists. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reubeno
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Linux targets Hyper-V/KVM, not Xen. The upstream grub.macros enables with_xen_arch and with_xen_pvh_arch on x86_64, producing grub2-xen-x64-modules and grub2-xen_pvh-i386-modules subpackages.
Force both to 0 via file-search-replace overlays on grub.macros. Verified: build succeeds and no Xen module subpackages are produced.