Skip to content

feat(rust-vm-memory): remove xen feature subpackage #16467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reubeno merged 1 commit into from
Apr 9, 2026
Merged

feat(rust-vm-memory): remove xen feature subpackage #16467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion base/comps/components.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6961,7 +6961,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml"]
[components.rust-virtio-bindings]
[components.rust-virtue]
[components.rust-vm-fdt]
[components.rust-vm-memory]
[components.rust-vmm-sys-util]
[components.rust-vmw_backdoor]
[components.rust-vsprintf]
Expand Down
20 changes: 20 additions & 0 deletions base/comps/rust-vm-memory/rust-vm-memory.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[components.rust-vm-memory]

# Remove the +xen feature subpackage — Xen is not applicable to Azure Linux.
[[components.rust-vm-memory.overlays]]
description = "Remove %package +xen-devel section"
type = "spec-remove-section"
section = "%package"
package = "%{name}+xen-devel"

[[components.rust-vm-memory.overlays]]
description = "Remove %description +xen-devel section"
type = "spec-remove-section"
section = "%description"
package = "%{name}+xen-devel"

[[components.rust-vm-memory.overlays]]
description = "Remove %files +xen-devel section"
type = "spec-remove-section"
section = "%files"
package = "%{name}+xen-devel"
Comment on lines +5 to +20
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type = "spec-remove-section" is not a recognized overlay type in the repo’s azldev schema (external/schemas/azldev.schema.json ComponentOverlay.type enum). As-is, this comp file is likely to fail schema-based validation/tooling or be ignored by overlay application. Use a supported overlay type (e.g., a scoped spec-search-replace that removes the %package block) or update the schema/tooling in the same PR to formally add spec-remove-section.

Suggested change
description = "Remove %package +xen-devel section"
type = "spec-remove-section"
section = "%package"
package = "%{name}+xen-devel"
[[components.rust-vm-memory.overlays]]
description = "Remove %description +xen-devel section"
type = "spec-remove-section"
section = "%description"
package = "%{name}+xen-devel"
[[components.rust-vm-memory.overlays]]
description = "Remove %files +xen-devel section"
type = "spec-remove-section"
section = "%files"
package = "%{name}+xen-devel"
description = "Remove the body of the %package +xen-devel section using a schema-supported overlay type"
type = "spec-search-replace"
section = "%package"
package = "+xen-devel"
regex = '^.*$'
replacement = ''
[[components.rust-vm-memory.overlays]]
description = "Remove the body of the %description +xen-devel section using a schema-supported overlay type"
type = "spec-search-replace"
section = "%description"
package = "+xen-devel"
regex = '^.*$'
replacement = ''
[[components.rust-vm-memory.overlays]]
description = "Remove the body of the %files +xen-devel section using a schema-supported overlay type"
type = "spec-search-replace"
section = "%files"
package = "+xen-devel"
regex = '^.*$'
replacement = ''

Copilot uses AI. Check for mistakes.
Comment on lines +4 to +20
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type = "spec-remove-section" does not appear in the repository’s azldev overlay type schema, so this overlay may not apply (or may fail validation). Consider rewriting this as a supported overlay operation or adding schema/tooling support for spec-remove-section.

Suggested change
[[components.rust-vm-memory.overlays]]
description = "Remove %package +xen-devel section"
type = "spec-remove-section"
section = "%package"
package = "%{name}+xen-devel"
[[components.rust-vm-memory.overlays]]
description = "Remove %description +xen-devel section"
type = "spec-remove-section"
section = "%description"
package = "%{name}+xen-devel"
[[components.rust-vm-memory.overlays]]
description = "Remove %files +xen-devel section"
type = "spec-remove-section"
section = "%files"
package = "%{name}+xen-devel"
# `spec-remove-section` is not a supported azldev overlay type, so use a scoped
# regex replacement as the schema-supported fallback for clearing these sections.
[[components.rust-vm-memory.overlays]]
description = "Clear the %package +xen-devel section because Xen is not shipped in Azure Linux"
type = "spec-search-replace"
section = "%package"
package = "%{name}+xen-devel"
regex = '^.*$'
replacement = ''
[[components.rust-vm-memory.overlays]]
description = "Clear the %description +xen-devel section because Xen is not shipped in Azure Linux"
type = "spec-search-replace"
section = "%description"
package = "%{name}+xen-devel"
regex = '^.*$'
replacement = ''
[[components.rust-vm-memory.overlays]]
description = "Clear the %files +xen-devel section because Xen is not shipped in Azure Linux"
type = "spec-search-replace"
section = "%files"
package = "%{name}+xen-devel"
regex = '^.*$'
replacement = ''

Copilot uses AI. Check for mistakes.
Comment on lines +5 to +20
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type = "spec-remove-section" is not listed as a valid overlay type in external/schemas/azldev.schema.json (ComponentOverlay.type enum). This risks breaking config consumers that validate against the schema. Prefer a supported overlay type (scoped to the relevant section/package) or update schema/tooling together with this change.

Suggested change
description = "Remove %package +xen-devel section"
type = "spec-remove-section"
section = "%package"
package = "%{name}+xen-devel"
[[components.rust-vm-memory.overlays]]
description = "Remove %description +xen-devel section"
type = "spec-remove-section"
section = "%description"
package = "%{name}+xen-devel"
[[components.rust-vm-memory.overlays]]
description = "Remove %files +xen-devel section"
type = "spec-remove-section"
section = "%files"
package = "%{name}+xen-devel"
description = "Remove the Xen devel subpackage declaration using a schema-supported overlay type"
type = "spec-search-replace"
regex = '^%package\\s+-n\\s+%\\{name\\}\\+xen-devel$'
replacement = ""
[[components.rust-vm-memory.overlays]]
description = "Clear the Xen devel subpackage description section using a schema-supported overlay type"
type = "spec-search-replace"
section = "%description"
package = "%{name}+xen-devel"
regex = '^.*$'
replacement = ""
[[components.rust-vm-memory.overlays]]
description = "Clear the Xen devel subpackage files section using a schema-supported overlay type"
type = "spec-search-replace"
section = "%files"
package = "%{name}+xen-devel"
regex = '^.*$'
replacement = ""

Copilot uses AI. Check for mistakes.
Loading