[0043] Update groupshared args proposal with information about overloads #748
Conversation
| declarations. In language modes before HLSL 202x, a warning will be produced, | ||
| but it should still be supported if the compiler supports the feature. | ||
| but it should still be supported if the compiler supports the feature. If the | ||
| compiler does not support the feature an error should be produced. |
There was a problem hiding this comment.
Is it optional for a compiler to support groupshared parameters? Or is this more of a "clang doesn't do this yet, but will eventually"?
There was a problem hiding this comment.
Any compiler that supports HLSL 202x should support this feature.
There was a problem hiding this comment.
Since all compilers under development should support the feature, I think this is just meant to capture the fact that prior versions of DXC compilers will produce an error in this case.
There was a problem hiding this comment.
Yes it essentially means any compiler which supports 202x supports this feature even if you don't use the 202x language mode. And yes to what @tex3d said.
There was a problem hiding this comment.
I see. I don't feel strongly about it but maybe a better wording is
In language modes before HLSL 202x, a warning will be produced,
but it should still be supported if the compiler supports HLSL 202x. If the
compiler does not support HLSL 202x an error should be produced.
"this feature" feels a bit vague while calling out that "support HLSL 202x implies support groupshared pre-HLSL 202x" feels a bit more precise
Not blocking on it though
4 participants
Update groupshared args proposal with info about overloads and error produced by old compilers.
Closes #745