Skip to content

Conversation

@csujedihy
Copy link
Collaborator

Description

Always use the latest base image for build dockers

Testing

CI

@csujedihy csujedihy requested a review from a team as a code owner August 28, 2025 17:39
@mtfriesen
Copy link
Contributor

Is it better to use dependabot to automatically update these? I see code warnings for the unpinned dependency.

@csujedihy
Copy link
Collaborator Author

Is it better to use dependabot to automatically update these? I see code warnings for the unpinned dependency.

I was puzzled by dependabot not updating the dockerfile so I made this PR. But, I just found a way to look at the dependabot logs and figured out why. There's a stale path in the config file.

mtfriesen
mtfriesen previously approved these changes Aug 28, 2025
@csujedihy csujedihy enabled auto-merge (squash) August 28, 2025 17:58
@codecov
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.52%. Comparing base (4b02044) to head (2f55c07).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5401      +/-   ##
==========================================
- Coverage   86.60%   85.52%   -1.09%     
==========================================
  Files          59       59              
  Lines       18328    18328              
==========================================
- Hits        15873    15675     -198     
- Misses       2455     2653     +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csujedihy csujedihy merged commit 2a84ded into main Aug 28, 2025
448 of 449 checks passed
@csujedihy csujedihy deleted the csujedihy-patch-1 branch August 28, 2025 19:13
penglei0 pushed a commit to penglei0/msquic that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants