Revert "chore: remove deprecated api process.binding (#653)"
#800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3913479.
|
After this is merged, would this require changes in VS Code itself? My remote development extension is partially broken and I'm wondering if I'll need to update my VS Code version or just the extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3913479.
Since the terminal
writemethod has no way to communicate backpressure to the caller and doesn't handle it internally, quickly successive calls towriteor calls with long enough data can cause a loop where the node process gets stuck repeatedly trying to write data that the terminal process did not read quickly enough.node-pty/src/interfaces.ts
Line 25 in 24b53bb
Fixes #797