Add InstanceMember flag to DeclarationFlags to enable membervar semantic token modifier for self.member#7890
Closed
Add InstanceMember flag to DeclarationFlags to enable membervar semantic token modifier for self.member#7890
Conversation
… modifier Co-authored-by: heejaechang <1333179+heejaechang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Investigate self.member not showing membervar modifier
Add InstanceMember flag to DeclarationFlags to enable membervar semantic token modifier for self.member
Feb 20, 2026
Contributor
Co-authored-by: heejaechang <1333179+heejaechang@users.noreply.github.com>
Contributor
Author
Renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self.memberinstance variables were not receiving themembervarsemantic token modifier because the protocol had no way to distinguish instance-level assignments (self.x = value) from class-level declarations (class Foo: x = value).Protocol changes
tsp.json(v0.2.0 → v0.3.0): AddedInstanceMember = 131072(1 << 17) toDeclarationFlags; renamedClassMember→ClassAttributewith corrected documentation (it marks any class attribute — method, class variable, or instance variable — as opposed to a standalone local variable or function)typeServerProtocol.ts(v0.4.0 → v0.5.0): AddedDeclarationFlagsconst enum and optionalflags?: DeclarationFlagsfield toRegularDeclarationTest file
Updated
semanticToken.pyto include both a class-level variable (expectedclassvarmodifier) and aself-assigned instance variable (expectedmembervarmodifier) to make the distinction explicit and testable.Original prompt
It points out the following behavior:
• self.member does not show a membervar modifier.
• Only variables explicitly declared using the syntax Class c: member = xx are marked as classvar.
This discrepancy makes it difficult to identify member variables consistently.
Request:Please investigate the behavior and provide clarification or a potential fix.</issue_description>
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.