Commit b637c59
committed
Move SearchQueryFilterClause to Plugins.Web and make FilterClause constructor public
Per reviewer feedback, moving SearchQueryFilterClause from Microsoft.Extensions.VectorData to Microsoft.SemanticKernel.Plugins.Web namespace as internal class, where it's actually used (Brave/Tavily connectors).
Changes:
- FilterClause.cs: Changed constructor from 'internal' to 'public' to allow external inheritance
- SearchQueryFilterClause.cs: Moved to Plugins.Web/FilterClauses/ as internal sealed class
- VectorData.Abstractions.csproj: Added CA1012 suppression (abstract types with public constructors)
Trade-off: Opening FilterClause to external inheritance is accepted to minimize MEVD public API surface.1 parent a689b0c commit b637c59
File tree
3 files changed
+10
-3
lines changed- dotnet/src
- Plugins/Plugins.Web/FilterClauses
- VectorData/VectorData.Abstractions
- FilterClauses
3 files changed
+10
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | | - | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
15 | 18 | | |
16 | 19 | | |
17 | 20 | | |
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
0 commit comments