Skip to content

.Net: Enable argument types retention in handoff orchestration. #13367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+9 −3
Open

.Net: Enable argument types retention in handoff orchestration. #13367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86af261
enable argument types retention for funciton calls for agents used in…
SergeyMenshykh Nov 17, 2025
8d117c9
fix build issue
SergeyMenshykh Nov 18, 2025
df03c59
use AsSpan method to convert array of floats to span
SergeyMenshykh Nov 18, 2025
78088d5
update milvus package
SergeyMenshykh Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
<PackageVersion Include="NRedisStack" Version="1.0.0" />
<PackageVersion Include="Milvus.Client" Version="2.3.0-preview.1" />
<PackageVersion Include="Testcontainers" Version="4.6.0" />
<PackageVersion Include="Testcontainers.Milvus" Version="4.6.0" />
<PackageVersion Include="Testcontainers.Milvus" Version="4.8.1" />
<PackageVersion Include="Testcontainers.MongoDB" Version="4.6.0" />
<PackageVersion Include="Testcontainers.PostgreSql" Version="4.6.0" />
<PackageVersion Include="Testcontainers.Qdrant" Version="4.6.0" />
Expand Down
8 changes: 7 additions & 1 deletion dotnet/src/Agents/Orchestration/Handoff/HandoffActor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,13 @@ protected override AgentInvokeOptions CreateInvokeOptions(Func<ChatMessageConten
new()
{
Kernel = kernel,
KernelArguments = new(new PromptExecutionSettings { FunctionChoiceBehavior = FunctionChoiceBehavior.Auto() }),
KernelArguments = new(new PromptExecutionSettings
{
FunctionChoiceBehavior = FunctionChoiceBehavior.Auto(options: new()
{
RetainArgumentTypes = true,
})
}),
OnIntermediateMessage = messageHandler,
};

Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/VectorData/SqliteVec/SqliteMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public TRecord MapFromStorageToDataModel(DbDataReader reader, bool includeVector
}

var floats = new float[length / 4];
var bytes = MemoryMarshal.Cast<float, byte>(floats);
var bytes = MemoryMarshal.Cast<float, byte>(floats.AsSpan());
stream.ReadExactly(bytes);
#else
var floats = MemoryMarshal.Cast<byte, float>((byte[])reader[ordinal]).ToArray();
Expand Down
Loading